git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 5/5] setup: report when GIT_OBJECT_DIRECTORY is what we could not use

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 28, 2026, 19:27 UTC
Message-ID
<xmqq4ie5aamt.fsf@gitster.g>
In-Reply-To
<20261028115412.169748-6-kaartic.sivaraam@gmail.com>
Kaartic Sivaraam <kaartic.sivaraam@gmail.com> writes:
Show 12 quoted lines
> Improve this error reporting UX by explaining the real cause wherever
> we are about to die. Because the check does not depend on the candidate
> that is given to is_git_directory(), it is enough to ask once, at the
> point of failure, whether the configured object directory is to blame.
> With this, the user would see the following:
>
>   ...
>   $ git status
>   fatal: not a git repository (or any parent up to mount point /)
>   Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
>   cannot access object directory '/tmp/git-objects' set via
>     $GIT_OBJECT_DIRECTORY: No such file or directory
Hmph, this is only a half of the real story isn't it?
    $ git status ;# to show I am in a healthy repository
    on branch master
    nothing to commit (use -u to show untracked files)

In such a healthy repository, if I have a bogus DB_ENVIRONMENT, discovery does not have to fail.

    $ GIT_OBJECT_DIRECTORY=/ git status
    fatal: bad object HEAD

On the other hand, if I am truly in a bogus non-repository, it does not matter where DB_ENVIRONMENT points at.

    $ (cd / && GIT_OBJECT_DIRECTORY=. git status)
    fatal: not a git repository (or any of the parent directories): .git
Even when DB_ENVIRONMENT points at a valid object directory
    $ (cd / && GIT_OBJECT_DIRECTORY=$HOME/w/git.git/.git/objects git status)
    fatal: not a git repository (or any of the parent directories): .git
the command fails because it cannot find a valid repository.
Show 18 quoted lines
> +static int describe_unusable_object_dir(struct strbuf *out)
> +{
> +	const char *objdir = getenv(DB_ENVIRONMENT);
> +	int saved_errno;
> +
> +	if (!objdir || !access(objdir, X_OK))
> +		return 0;
> +	saved_errno = errno;
> +
> +	/*
> +	 * TRANSLATORS: The first %s is a path, the second %s is the
> +	 * name of the environment variable that set it, and the third
> +	 * %s is the system error message.
> +	 */
> +	strbuf_addf(out, _("cannot access object directory '%s' set via $%s: %s"),
> +		    objdir, DB_ENVIRONMENT, strerror(saved_errno));
> +	return 1;
> +}

As this is called ONLY when we cannot figure out a usable GIT_DIR, we do not have to worry about a case where $GIT_OBJECT_DIRECTORY is not set and $GIT_DIR/objects/ is not readable. So I do not think this additional message hurts much, but I am not sure how much it would help. It would make the message more confusing in the "no valid repository, DB_ENVIRONMENT pointing at a healthy object directory" situation in the above example.

Previous: Kaartic SivaraamNext: Junio C Hamano
Message 29 of 30 in “Improve error reporting to mention "why" a directory is not a repository”
  1. 0/3 Improve error reporting to mention "why" a directory is not a repositoryKaartic Sivaraam, Sep 24, 2026
  2. 1/3 t0009: add tests to cover more error reporting scenariosKaartic Sivaraam, Sep 24, 2026
  3. Junio C HamanoSep 24, 2026
  4. Kaartic SivaraamSep 25, 2026
  5. 2/3 setup: introduce new helper 'is_git_directory_verbose'Kaartic Sivaraam, Sep 24, 2026
  6. Junio C HamanoSep 24, 2026
  7. Kaartic SivaraamSep 25, 2026
  8. 3/3 setup: communicate why a directory is not a valid git directoryKaartic Sivaraam, Sep 24, 2026
  9. Junio C HamanoSep 24, 2026
  10. Kaartic SivaraamSep 25, 2026
  11. 0/4 Improve error reporting to mention "why" a directory is not a repositoryKaartic Sivaraam, Sep 29, 2026
  12. 1/4 setup: normalize an if-else to follow our conventionKaartic Sivaraam, Sep 29, 2026
  13. 2/4 t0009: add tests to cover more error reporting scenariosKaartic Sivaraam, Sep 29, 2026
  14. 3/4 setup: introduce new helper 'is_git_directory_verbose'Kaartic Sivaraam, Sep 29, 2026
  15. Patrick SteinhardtSep 30, 2026
  16. Kaartic SivaraamOct 5, 2026
  17. Junio C HamanoSep 30, 2026
  18. Kaartic SivaraamOct 28, 2026
  19. 4/4 setup: communicate why a directory is not a valid git directoryKaartic Sivaraam, Sep 29, 2026
  20. Patrick SteinhardtSep 30, 2026
  21. Kaartic SivaraamOct 5, 2026
  22. 0/5 Improve error reporting to mention how a Git repository is discoveredKaartic Sivaraam, Oct 28, 2026
  23. 1/5 setup: normalize an if-else to follow our conventionKaartic Sivaraam, Oct 28, 2026
  24. 2/5 t0009: add tests to cover more repository discovery scenariosKaartic Sivaraam, Oct 28, 2026
  25. 3/5 setup: provide hint about the source of the explicit git directoryKaartic Sivaraam, Oct 28, 2026
  26. 4/5 setup: provide hint about auto-discovery boundariesKaartic Sivaraam, Oct 28, 2026
  27. Junio C HamanoOct 28, 2026
  28. 5/5 setup: report when GIT_OBJECT_DIRECTORY is what we could not useKaartic Sivaraam, Oct 28, 2026
  29. Junio C HamanoOct 28, 2026
  30. Junio C HamanoOct 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.