Re: [RFC PATCH 1/3] t0009: add tests to cover more error reporting scenarios

From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date: Sep 25, 2026, 13:46 UTC
Message-ID: <b024b447-4c63-494c-8ffc-f700fb3c7c46@gmail.com>
In-Reply-To: <xmqqjyoaz4ig.fsf@gitster.g>

On 9/25/26 03:38, Junio C Hamano wrote:

Show 29 quoted lines

> Kaartic Sivaraam <kaartic.sivaraam@gmail.com> writes:
> 
>> Introduce few more tests to t0009 to cover error reporting scenarios
>> when --git-dir is used.
>>
>> Signed-off-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
>> ---
>>   t/t0009-git-dir-validation.sh | 36 +++++++++++++++++++++++++++++++++++
>>   1 file changed, 36 insertions(+)
>>
>> diff --git a/t/t0009-git-dir-validation.sh b/t/t0009-git-dir-validation.sh
>> index 4cba478e50..244dc07c0e 100755
>> --- a/t/t0009-git-dir-validation.sh
>> +++ b/t/t0009-git-dir-validation.sh
>> @@ -74,4 +74,40 @@ test_expect_success 'setup: .git as an empty directory is ignored' '
>>   	)
>>   '
>>   
>> +test_expect_success 'setup: custom git directory with missing HEAD is rejected' '
>> +	test_when_finished "rm -rf parent/empty-dir" &&
>> +	mkdir -p parent/empty-dir &&
>> +	(
>> +		test_must_fail git --git-dir parent/empty-dir rev-parse --is-bare-repository 2>stderr &&
>> +		test_grep "not a git repository" stderr
>> +	)
>> +'
> 
> Why subshell?
>

Good catch. It is unnecessary. An earlier iteration used to cd into parent/empty-dir. This is no longer the case. So, I'll avoid the sub-shell in this test.

-- 
Sivaraam