git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/5] setup: normalize an if-else to follow our convention

From
Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date
Oct 28, 2026, 11:53 UTC
Message-ID
<20261028115412.169748-2-kaartic.sivaraam@gmail.com>
In-Reply-To
<20261028115412.169748-1-kaartic.sivaraam@gmail.com>

The else case was not stuck with the corresponding if's closing brace which is not in-line with our convention. Fix the same.

This is a style-only change; no behaviour change intended.
Signed-off-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
---
 setup.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/setup.c b/setup.c
index 61bcdafe82..4789b2d79d 100644
--- a/setup.c
+++ b/setup.c
@@ -1905,8 +1905,7 @@ const char *enter_repo(struct repository *repo, const char *path, unsigned flags
 		if (chdir(used_path.buf))
 			return NULL;
 		path = validated_path.buf;
-	}
-	else {
+	} else {
 		const char *gitfile = read_gitfile(path);
 		if (!(flags & ENTER_REPO_ANY_OWNER_OK))
 			die_upon_dubious_ownership(gitfile, NULL, path);
-- 
2.55.0.1003.g10538fe699
Previous: Kaartic SivaraamNext: Kaartic Sivaraam
Message 23 of 30 in “Improve error reporting to mention "why" a directory is not a repository”
  1. 0/3 Improve error reporting to mention "why" a directory is not a repositoryKaartic Sivaraam, Sep 24, 2026
  2. 1/3 t0009: add tests to cover more error reporting scenariosKaartic Sivaraam, Sep 24, 2026
  3. Junio C HamanoSep 24, 2026
  4. Kaartic SivaraamSep 25, 2026
  5. 2/3 setup: introduce new helper 'is_git_directory_verbose'Kaartic Sivaraam, Sep 24, 2026
  6. Junio C HamanoSep 24, 2026
  7. Kaartic SivaraamSep 25, 2026
  8. 3/3 setup: communicate why a directory is not a valid git directoryKaartic Sivaraam, Sep 24, 2026
  9. Junio C HamanoSep 24, 2026
  10. Kaartic SivaraamSep 25, 2026
  11. 0/4 Improve error reporting to mention "why" a directory is not a repositoryKaartic Sivaraam, Sep 29, 2026
  12. 1/4 setup: normalize an if-else to follow our conventionKaartic Sivaraam, Sep 29, 2026
  13. 2/4 t0009: add tests to cover more error reporting scenariosKaartic Sivaraam, Sep 29, 2026
  14. 3/4 setup: introduce new helper 'is_git_directory_verbose'Kaartic Sivaraam, Sep 29, 2026
  15. Patrick SteinhardtSep 30, 2026
  16. Kaartic SivaraamOct 5, 2026
  17. Junio C HamanoSep 30, 2026
  18. Kaartic SivaraamOct 28, 2026
  19. 4/4 setup: communicate why a directory is not a valid git directoryKaartic Sivaraam, Sep 29, 2026
  20. Patrick SteinhardtSep 30, 2026
  21. Kaartic SivaraamOct 5, 2026
  22. 0/5 Improve error reporting to mention how a Git repository is discoveredKaartic Sivaraam, Oct 28, 2026
  23. 1/5 setup: normalize an if-else to follow our conventionKaartic Sivaraam, Oct 28, 2026
  24. 2/5 t0009: add tests to cover more repository discovery scenariosKaartic Sivaraam, Oct 28, 2026
  25. 3/5 setup: provide hint about the source of the explicit git directoryKaartic Sivaraam, Oct 28, 2026
  26. 4/5 setup: provide hint about auto-discovery boundariesKaartic Sivaraam, Oct 28, 2026
  27. Junio C HamanoOct 28, 2026
  28. 5/5 setup: report when GIT_OBJECT_DIRECTORY is what we could not useKaartic Sivaraam, Oct 28, 2026
  29. Junio C HamanoOct 28, 2026
  30. Junio C HamanoOct 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.