Re: [PATCH v2] odb: do not list our own refs as alternate refs in the quarantine
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 4, 2026, 18:05 UTC
- Message-ID
- <xmqq4idw320z.fsf@gitster.g>
- In-Reply-To
- <CAL71e4OreARF+dbCU3S8-_umrFEptPLPUiPDH3SYBx6OYjVpfg@mail.gmail.com>
Kristofer Karlsson <krka@spotify.com> writes:
Show 11 quoted lines
>> That's how _we_ use them in the internal callers, but it's a rev-list >> option. So we can't say how they are used elsewhere. That said, I think >> this is a totally reasonable tightening of the definition for general >> use. > > Good point. I will reword that part of the commit message so that it > does not rely on how the connectivity check uses them. It also seems > in line with what we already do when loading alternates, where > listing the object directory itself is ignored as a common mistake; > inside the quarantine, that check just compares against the > quarantine instead of our own object directory.
Sounds very good. Thanks for coming up with a good way forward.