git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] odb: do not list our own refs as alternate refs in the quarantine

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 4, 2026, 18:05 UTC
Message-ID
<xmqq4idw320z.fsf@gitster.g>
In-Reply-To
<CAL71e4OreARF+dbCU3S8-_umrFEptPLPUiPDH3SYBx6OYjVpfg@mail.gmail.com>
Kristofer Karlsson <krka@spotify.com> writes:
Show 11 quoted lines
>> That's how _we_ use them in the internal callers, but it's a rev-list
>> option. So we can't say how they are used elsewhere. That said, I think
>> this is a totally reasonable tightening of the definition for general
>> use.
>
> Good point.  I will reword that part of the commit message so that it
> does not rely on how the connectivity check uses them.  It also seems
> in line with what we already do when loading alternates, where
> listing the object directory itself is ignored as a common mistake;
> inside the quarantine, that check just compares against the
> quarantine instead of our own object directory.

Sounds very good. Thanks for coming up with a good way forward.

Previous: Kristofer Karlsson
Message 20 of 20 in “odb: do not list our own refs as alternate refs in the quarantine”
  1. odb: do not list our own refs as alternate refs in the quarantineKristofer Karlsson via GitGitGadget, Oct 28, 2026
  2. Justin ToblerOct 29, 2026
  3. Kristofer KarlssonOct 30, 2026
  4. Junio C HamanoOct 29, 2026
  5. Kristofer KarlssonOct 30, 2026
  6. Junio C HamanoOct 30, 2026
  7. Jeff KingOct 30, 2026
  8. odb: do not list our own refs as alternate refs in the quarantineKristofer Karlsson via GitGitGadget, Nov 2, 2026
  9. Junio C HamanoNov 3, 2026
  10. Junio C HamanoNov 3, 2026
  11. Kristofer KarlssonNov 3, 2026
  12. Patrick SteinhardtNov 3, 2026
  13. Kristofer KarlssonNov 3, 2026
  14. Patrick SteinhardtNov 3, 2026
  15. Justin ToblerNov 3, 2026
  16. Kristofer KarlssonNov 4, 2026
  17. Justin ToblerNov 4, 2026
  18. Jeff KingNov 4, 2026
  19. Kristofer KarlssonNov 4, 2026
  20. Junio C HamanoNov 4, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.