Re: [PATCH v2] odb: do not list our own refs as alternate refs in the quarantine

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 3, 2026, 00:37 UTC
Message-ID: <xmqq1p92g375.fsf@gitster.g>
In-Reply-To: <pull.2285.v2.git.1793619933300.gitgitgadget@gmail.com>

"Kristofer Karlsson via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 15 quoted lines

>     Changes since v1:
>     
>      * Changed the rule to "an alternate that is ourselves is not a source
>        of alternate refs", as Peff described it.
>     
>      * Added a "borrowed" flag to alternates, set when they are loaded,
>        which says whether they come from another repository, and used it for
>        --alternate-refs. Our own object directory is recognized either as
>        /objects or as the parent of GIT_QUARANTINE_PATH.
>     
>      * Documented this for --alternate-refs.
>     
>      * Added tests for rev-list --alternate-refs in a pre-receive hook, for
>        our own object directory set up as an alternate by hand, and for a
>        quarantine outside of the commondir.

All of the above changes make sense to me.

This unfortunately crashes with Patrick's odb-reload-alternates series, but let me see if I can get a reasonable conflict resolution or if it is more reasonable to ask you to rebase this on the other topic.

Thanks.