git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] odb: do not list our own refs as alternate refs in the quarantine

From
Patrick Steinhardt <ps@pks.im>
Date
Nov 3, 2026, 12:26 UTC
Message-ID
<aunS6dE0B-JAJnBk@pks.im>
In-Reply-To
<CAL71e4McZzVJqFHnmpoQkC6+hUkhz9_HtEy7dqC5rDyXdV6oaQ@mail.gmail.com>
On Tue, Nov 03, 2026 at 01:05:29PM +0100, Kristofer Karlsson wrote:
Show 12 quoted lines
> On Tue, Nov 03, 2026 at 12:00 PM Patrick Steinhardt <ps@pks.im> wrote:
> > So this here isn't fully correct as it does not account for all cases.
> > We'd have to read the object storage format extension to figure out
> > where the primary object directory lives.
> 
> Good point.  I can rework the patch to make it easier to integrate
> with your ps/odb-object-storage-extension topic, by having the files
> source remember its default object directory in
> files->default_object_dir where it decides it, and comparing against
> that instead of hardcoding <commondir>/objects in the check.  Then
> your topic only has to change how the default is decided, and the
> check follows.  Something like this, if you want:

Note that this topic is already merged to "next", so in theory you could rebase your patch on top of it now.

Show 14 quoted lines
> > This makes me wonder whether the better fix would be to stop modifying
> > the primary object directory and instead we simply append the quarantine
> > directory to alternates.
> [...]
> 
> That does sound like the cleaner fix.  Since you are already deep into
> this area, I would be happy to drop the fix and wait for that instead.
> I expect very few users to be affected in practice: mostly git hosts
> with many hidden refs, which is the case bcec6780b2 was about.
> 
> In that case I could send just the tests, with the hidden refs case
> marked as test_expect_failure, so that it is covered once a long-term
> fix lands.  Or, if you would rather have a short-term fix in the
> meantime, I can send a v3 with the change above.

I certainly do care about this case and would like to see this fixed :) I'd like to get Justin's opinion on that proposal first though, as he's worked on transactions quite extensively over the last couple months.

Patrick
Previous: Kristofer Karlsson
Message 14 of 14 in “odb: do not list our own refs as alternate refs in the quarantine”
  1. odb: do not list our own refs as alternate refs in the quarantineKristofer Karlsson via GitGitGadget, Oct 28, 2026
  2. Justin ToblerOct 29, 2026
  3. Kristofer KarlssonOct 30, 2026
  4. Junio C HamanoOct 29, 2026
  5. Kristofer KarlssonOct 30, 2026
  6. Junio C HamanoOct 30, 2026
  7. Jeff KingOct 30, 2026
  8. odb: do not list our own refs as alternate refs in the quarantineKristofer Karlsson via GitGitGadget, Nov 2, 2026
  9. Junio C HamanoNov 3, 2026
  10. Junio C HamanoNov 3, 2026
  11. Kristofer KarlssonNov 3, 2026
  12. Patrick SteinhardtNov 3, 2026
  13. Kristofer KarlssonNov 3, 2026
  14. Patrick SteinhardtNov 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.