git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test the commit.gpgsign config option

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 16, 2013, 17:05 UTC
Message-ID
<xmqq38lsrakh.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1387202104-17580-1-git-send-email-boklm@mars-attacks.org>
Nicolas Vigier <boklm@mars-attacks.org> writes:
Show 43 quoted lines
> The tests are checking that :
>
> - when commit.gpgsign is true, "git commit" creates signed commits
>
> - when commit.gpgsign is false, "git commit" creates unsigned commits
>
> - when commit.gpgsign is true, "git commit --no-gpg-sign" creates
>   unsigned commits
>
> - when commit.gpgsign is true, "git rebase -f" creates signed commits
>
> Signed-off-by: Nicolas Vigier <boklm@mars-attacks.org>
> ---
>  t/t7510-signed-commit.sh | 25 +++++++++++++++++++++----
>  1 file changed, 21 insertions(+), 4 deletions(-)
>
> diff --git a/t/t7510-signed-commit.sh b/t/t7510-signed-commit.sh
> index 1d3c56fe61fa..537bfba76ecf 100755
> --- a/t/t7510-signed-commit.sh
> +++ b/t/t7510-signed-commit.sh
> @@ -25,12 +25,29 @@ test_expect_success GPG 'create signed commits' '
>  	git tag fourth-unsigned &&
>  
>  	test_tick && git commit --amend -S -m "fourth signed" &&
> -	git tag fourth-signed
> +	git tag fourth-signed &&
> +
> +	git config commit.gpgsign true &&
> +	echo 5 >file && test_tick && git commit -a -m "fifth signed" &&
> +	git tag fifth-signed &&
> +
> +	git config commit.gpgsign false &&
> +	echo 6 >file && test_tick && git commit -a -m "sixth" &&
> +	git tag sixth-unsigned &&
> +
> +	git config commit.gpgsign true &&
> +	echo 7 >file && test_tick && git commit -a -m "seventh" --no-gpg-sign &&
> +	git tag seventh-unsigned &&
> +
> +	test_tick && git rebase -f HEAD^^ && git tag sixth-signed HEAD^ &&
> +	git tag seventh-signed &&
> +
> +	git config --unset commit.gpgsign

If any of the above fail, the next test will run with an unknown random value in commit.gpgsign depending on where the sequence failed. Use one test_when_finished with test_unconfig at the very beginning, perhaps.

Previous: Nicolas VigierNext: Junio C Hamano
Message 10 of 11 in “What's cooking in git.git (Dec 2013, #03; Thu, 12)”
  1. Junio C HamanoDec 13, 2013
  2. Duy NguyenDec 13, 2013
  3. Junio C HamanoDec 13, 2013
  4. Torsten BögershausenDec 13, 2013
  5. Junio C HamanoDec 13, 2013
  6. Junio C HamanoDec 16, 2013
  7. Nicolas VigierDec 16, 2013
  8. Junio C HamanoDec 16, 2013
  9. test the commit.gpgsign config optionNicolas Vigier, Dec 16, 2013
  10. Junio C HamanoDec 16, 2013
  11. Junio C HamanoDec 17, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.