From: Junio C Hamano Date: Mon, 16 Dec 2013 17:05:02 GMT Subject: Re: [PATCH] test the commit.gpgsign config option Message-ID: In-Reply-To: <1387202104-17580-1-git-send-email-boklm@mars-attacks.org> Nicolas Vigier writes: > The tests are checking that : > > - when commit.gpgsign is true, "git commit" creates signed commits > > - when commit.gpgsign is false, "git commit" creates unsigned commits > > - when commit.gpgsign is true, "git commit --no-gpg-sign" creates > unsigned commits > > - when commit.gpgsign is true, "git rebase -f" creates signed commits > > Signed-off-by: Nicolas Vigier > --- > t/t7510-signed-commit.sh | 25 +++++++++++++++++++++---- > 1 file changed, 21 insertions(+), 4 deletions(-) > > diff --git a/t/t7510-signed-commit.sh b/t/t7510-signed-commit.sh > index 1d3c56fe61fa..537bfba76ecf 100755 > --- a/t/t7510-signed-commit.sh > +++ b/t/t7510-signed-commit.sh > @@ -25,12 +25,29 @@ test_expect_success GPG 'create signed commits' ' > git tag fourth-unsigned && > > test_tick && git commit --amend -S -m "fourth signed" && > - git tag fourth-signed > + git tag fourth-signed && > + > + git config commit.gpgsign true && > + echo 5 >file && test_tick && git commit -a -m "fifth signed" && > + git tag fifth-signed && > + > + git config commit.gpgsign false && > + echo 6 >file && test_tick && git commit -a -m "sixth" && > + git tag sixth-unsigned && > + > + git config commit.gpgsign true && > + echo 7 >file && test_tick && git commit -a -m "seventh" --no-gpg-sign && > + git tag seventh-unsigned && > + > + test_tick && git rebase -f HEAD^^ && git tag sixth-signed HEAD^ && > + git tag seventh-signed && > + > + git config --unset commit.gpgsign If any of the above fail, the next test will run with an unknown random value in commit.gpgsign depending on where the sequence failed. Use one test_when_finished with test_unconfig at the very beginning, perhaps.