git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test the commit.gpgsign config option

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 17, 2013, 23:27 UTC
Message-ID
<xmqqr49bkqi7.fsf@gitster.dls.corp.google.com>
In-Reply-To
<xmqq38lsrakh.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
> If any of the above fail, the next test will run with an unknown
> random value in commit.gpgsign depending on where the sequence
> failed.  Use one test_when_finished with test_unconfig at the very
> beginning, perhaps.
In other words, I'll squash this in.
diff --git a/t/t7510-signed-commit.sh b/t/t7510-signed-commit.sh
index 537bfba..5ddac1a 100755
--- a/t/t7510-signed-commit.sh
+++ b/t/t7510-signed-commit.sh
@@ -5,6 +5,8 @@ test_description='signed commit tests'
 . "$TEST_DIRECTORY/lib-gpg.sh"
 
 test_expect_success GPG 'create signed commits' '
+	test_when_finished "test_unconfig commit.gpgsign" &&
+
 	echo 1 >file && git add file &&
 	test_tick && git commit -S -m initial &&
 	git tag initial &&
@@ -40,9 +42,7 @@ test_expect_success GPG 'create signed commits' '
 	git tag seventh-unsigned &&
 
 	test_tick && git rebase -f HEAD^^ && git tag sixth-signed HEAD^ &&
-	git tag seventh-signed &&
-
-	git config --unset commit.gpgsign
+	git tag seventh-signed
 '
 
 test_expect_success GPG 'show signatures' '
Previous: Junio C Hamano
Message 11 of 11 in “What's cooking in git.git (Dec 2013, #03; Thu, 12)”
  1. Junio C HamanoDec 13, 2013
  2. Duy NguyenDec 13, 2013
  3. Junio C HamanoDec 13, 2013
  4. Torsten BögershausenDec 13, 2013
  5. Junio C HamanoDec 13, 2013
  6. Junio C HamanoDec 16, 2013
  7. Nicolas VigierDec 16, 2013
  8. Junio C HamanoDec 16, 2013
  9. test the commit.gpgsign config optionNicolas Vigier, Dec 16, 2013
  10. Junio C HamanoDec 16, 2013
  11. Junio C HamanoDec 17, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.