git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/6] t/diff-lib: check exact object names in compare_diff_raw

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 23, 2015, 19:45 UTC
Message-ID
<xmqq385wtns5.fsf@gitster.dls.corp.google.com>
In-Reply-To
<54EB6E17.5040102@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 15 quoted lines
>> diff --git a/t/diff-lib.sh b/t/diff-lib.sh
>> index 75a35fc..c211dc4 100644
>> --- a/t/diff-lib.sh
>> +++ b/t/diff-lib.sh
>> @@ -1,6 +1,6 @@
>>   :
>>   
>> -sanitize_diff_raw='/^:/s/ '"$_x40"' '"$_x40"' \([A-Z]\)[0-9]*	/ X X \1#	/'
>> +sanitize_diff_raw='/^:/s/ '"\($_x40\)"' '"\($_x40\)"' \([A-Z]\)[0-9]*	/ \1 \2 \3#	/'
>>   compare_diff_raw () {
>>       # When heuristics are improved, the score numbers would change.
>>       # Ignore them while comparing.
>> 
>
> This reveals a minor bug in test_ln_s_add:
Thanks for catching it before it hits 'master'.
Previous: Johannes SixtNext: Junio C Hamano
Message 8 of 10 in “test updates around diff”
  1. 0/6 test updates around diffJunio C Hamano, Feb 15, 2015
  2. 1/6 t4008: correct stale commentsJunio C Hamano, Feb 15, 2015
  3. 2/6 t9300: correct expected object namesJunio C Hamano, Feb 15, 2015
  4. 3/6 t4010: correct expected object namesJunio C Hamano, Feb 15, 2015
  5. 4/6 tests: do not borrow from COPYING and README from the real sourceJunio C Hamano, Feb 15, 2015
  6. 5/6 t/diff-lib: check exact object names in compare_diff_rawJunio C Hamano, Feb 15, 2015
  7. Johannes SixtFeb 23, 2015
  8. Junio C HamanoFeb 23, 2015
  9. 6/6 t4008: modernise styleJunio C Hamano, Feb 15, 2015
  10. Jeff KingFeb 16, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.