git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/6] t4008: correct stale comments

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 15, 2015, 23:43 UTC
Message-ID
<1424043824-25242-2-git-send-email-gitster@pobox.com>
In-Reply-To
<1424043824-25242-1-git-send-email-gitster@pobox.com>

A complete rewrite of a single file was originally designed to be expressed as a deletion immediately followed by a creation of the same file, and the comments in the test updated here were written to reflect that design decision made in f345b0a0 (Add -B flag to diff-* brothers., 2005-05-30). However, we later realized that a complete rewrite is merely how a textual diff should be represented at 366175ef (Rework -B output., 2005-06-19), and updated the actual tests. But we forgot to update the introductory text while doing so.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t4008-diff-break-rewrite.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t4008-diff-break-rewrite.sh b/t/t4008-diff-break-rewrite.sh
index 8920464..a4e771b 100755
--- a/t/t4008-diff-break-rewrite.sh
+++ b/t/t4008-diff-break-rewrite.sh
@@ -10,14 +10,14 @@ We have two very different files, file0 and file1, registered in a tree.
 We update file1 so drastically that it is more similar to file0, and
 then remove file0.  With -B, changes to file1 should be broken into
 separate delete and create, resulting in removal of file0, removal of
-original file1 and creation of completely rewritten file1.
+original file1 and creation of completely rewritten file1.  The latter
+two are then merged back into a single "complete rewrite".
 
 Further, with -B and -M together, these three modifications should
 turn into rename-edit of file0 into file1.
 
 Starting from the same two files in the tree, we swap file0 and file1.
-With -B, this should be detected as two complete rewrites, resulting in
-four changes in total.
+With -B, this should be detected as two complete rewrites.
 
 Further, with -B and -M together, these should turn into two renames.
 '
-- 
2.3.0-266-g5b48884
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 10 in “test updates around diff”
  1. 0/6 test updates around diffJunio C Hamano, Feb 15, 2015
  2. 1/6 t4008: correct stale commentsJunio C Hamano, Feb 15, 2015
  3. 2/6 t9300: correct expected object namesJunio C Hamano, Feb 15, 2015
  4. 3/6 t4010: correct expected object namesJunio C Hamano, Feb 15, 2015
  5. 4/6 tests: do not borrow from COPYING and README from the real sourceJunio C Hamano, Feb 15, 2015
  6. 5/6 t/diff-lib: check exact object names in compare_diff_rawJunio C Hamano, Feb 15, 2015
  7. Johannes SixtFeb 23, 2015
  8. Junio C HamanoFeb 23, 2015
  9. 6/6 t4008: modernise styleJunio C Hamano, Feb 15, 2015
  10. Jeff KingFeb 16, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.