git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/6] t9300: correct expected object names

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 15, 2015, 23:43 UTC
Message-ID
<1424043824-25242-3-git-send-email-gitster@pobox.com>
In-Reply-To
<1424043824-25242-1-git-send-email-gitster@pobox.com>

The output the test #36 expects is bogus. There are no blob objects whose names are 36a590... or 046d037... when this test was run.

It was left unnoticed only because compare_diff_raw, which only cares about the add/delete/rename/copy was used to check the result.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t9300-fast-import.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh
index 27263df..e53def2 100755
--- a/t/t9300-fast-import.sh
+++ b/t/t9300-fast-import.sh
@@ -582,8 +582,8 @@ test_expect_success 'D: verify pack' '
 '
 
 cat >expect <<EOF
-:000000 100755 0000000000000000000000000000000000000000 35a59026a33beac1569b1c7f66f3090ce9c09afc A	newdir/exec.sh
-:000000 100644 0000000000000000000000000000000000000000 046d0371e9220107917db0d0e030628de8a1de9b A	newdir/interesting
+:000000 100755 0000000000000000000000000000000000000000 e74b7d465e52746be2b4bae983670711e6e66657 A	newdir/exec.sh
+:000000 100644 0000000000000000000000000000000000000000 fcf778cda181eaa1cbc9e9ce3a2e15ee9f9fe791 A	newdir/interesting
 EOF
 git diff-tree -M -r branch^ branch >actual
 test_expect_success \
-- 
2.3.0-266-g5b48884
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 10 in “test updates around diff”
  1. 0/6 test updates around diffJunio C Hamano, Feb 15, 2015
  2. 1/6 t4008: correct stale commentsJunio C Hamano, Feb 15, 2015
  3. 2/6 t9300: correct expected object namesJunio C Hamano, Feb 15, 2015
  4. 3/6 t4010: correct expected object namesJunio C Hamano, Feb 15, 2015
  5. 4/6 tests: do not borrow from COPYING and README from the real sourceJunio C Hamano, Feb 15, 2015
  6. 5/6 t/diff-lib: check exact object names in compare_diff_rawJunio C Hamano, Feb 15, 2015
  7. Johannes SixtFeb 23, 2015
  8. Junio C HamanoFeb 23, 2015
  9. 6/6 t4008: modernise styleJunio C Hamano, Feb 15, 2015
  10. Jeff KingFeb 16, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.