Re: [PATCH v2 3/4] strbuf_setlen: don't write to strbuf_slopbuf
Brandon Casey <drafnel@gmail.com> writes:
Show 13 quoted lines
> On Wed, Aug 23, 2017 at 2:04 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Brandon Casey <drafnel@gmail.com> writes:
>>
>>> So is there any reason why didn't do something like the following in
>>> the first place?
>>
>> My guess is that we didn't bother; if we cared, we would have used a
>> single instance of const char in a read-only segment, instead of
>> such a macro.
>
> I think you mean something like this:
>
> const char * const strbuf_slopbuf = "";
Rather, more like "const char slopbuf[1];"