Re: [PATCH] hashmap: add API to disable item counting when threaded

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Sep 5, 2017, 16:39 UTC
Message-ID: <06c552de-80a0-9cd0-d016-07a4ab0afaf0@jeffhostetler.com>
In-Reply-To: <20170901235030.GD143138@aiede.mtv.corp.google.com>

On 9/1/2017 7:50 PM, Jonathan Nieder wrote:

Show 14 quoted lines

> Hi,
> 
> Johannes Schindelin wrote:
>> On Wed, 30 Aug 2017, Jeff Hostetler wrote:
> 
>>> This is to address concerns raised by ThreadSanitizer on the mailing
>>> list about threaded unprotected R/W access to map.size with my previous
>>> "disallow rehash" change (0607e10009ee4e37cb49b4cec8d28a9dda1656a4).
> 
> Nice!
> 
> What does the message from TSan look like?  (The full message doesn't
> need to go in the commit message, but a snippet can help.)  How can I
> reproduce it?

I'll let Martin common on how to run TSan; I'm just going on what he reported in the "tsan: t3008..." message from the URL I quoted. I didn't think to copy that text into the commit message because it is just stack traces and too long, but I could include a snippet.

Thanks, Jeff