[PATCH v2] hashmap: address ThreadSanitizer concerns
- From
- Jeff Hostetler <git@jeffhostetler.com>
- Date
- Sep 6, 2017, 15:43 UTC
- Message-ID
- <20170906154348.14287-1-git@jeffhostetler.com>
- In-Reply-To
- <20170830185922.10107-1-git@jeffhostetler.com>
From: Jeff Hostetler <jeffhost@microsoft.com>
Version 2 addresses the comments and suggestions on version 1. It removes the explicit disable/enable rehash and just relies on the state of hashmap counting. It changes the declaration of the hashmap_get_size() to be static to avoid issues seen on some compilers. It uses BUG() rather than die() for an error condition. It adds a comment describing why lazy-init needs to disable couting. It fixes line length problems. It add details from TSan in the commit message.
Jeff Hostetler (1): hashmap: add API to disable item counting when threaded
attr.c | 15 ++++++----- builtin/describe.c | 2 +- hashmap.c | 26 +++++++++++------- hashmap.h | 72 ++++++++++++++++++++++++++++++++++--------------- name-hash.c | 10 +++++-- t/helper/test-hashmap.c | 3 ++- 6 files changed, 88 insertions(+), 40 deletions(-)
-- 2.9.3