Re: [PATCH v2 6/8] travis-ci: don't install 'language-pack-is' package
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 18, 2017, 22:34 UTC
- Message-ID
- <xmqq3747y8b0.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <AB053B56-5318-47D4-8ADE-0A72B9860BED@gmail.com>
Lars Schneider <larsxschneider@gmail.com> writes:
Show 5 quoted lines
>> It seems we would loose coverage with this patch, so it should be >> dropped. > > Yeah. I think we should add a comment to the travis.yml to avoid > future confusion. I'll do it unless you beat me to it with a re-roll.
Rather, it should be commented close to where is locale is used in tests, and possibly in t/README, I would think. Those who want to use t/*, not necessarily using Travis, would benefit from the hint, "installing icelandic locale may give you better test coverage", or something like that.