Re: [PATCH 1/4] travis-ci: use 'set -x' in 'ci/*' scripts for extra tracing output
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Dec 15, 2017, 15:32 UTC
- Message-ID
- <alpine.DEB.2.21.1.1712151632140.406@MININT-6BKU6QN.europe.corp.microsoft.com>
- In-Reply-To
- <CAM0VKjmpJ_J+GjJ3PyU_pxsWx85L6cPa2tLM0xJx3cJu2T87Zg@mail.gmail.com>
Hi Gábor,
On Fri, 15 Dec 2017, SZEDER Gábor wrote:
Show 22 quoted lines
> On Fri, Dec 15, 2017 at 1:10 PM, Johannes Schindelin > <Johannes.Schindelin@gmx.de> wrote: > > > >> There is a lot going on in 'run-windows-build.sh', so the output of > >> 'set -x' might be useful or might be considered too much clutter, I > >> don't know. I put Dscho on Cc, I think it's mainly his call. > > > > Certainly it might be useful. > > > > However, please make sure that the secret token is not leaked that > > way. Like, *really* sure. Due to the failure of Git to use a portable > > and performant test suite, it does take about 90 minutes to build and > > test a revision, therefore it would be very easy to DOS my build > > system, and I really, really need it not to be DOSed because I use it > > in my day job, too. > > Ugh, I was completely unaware of this issue, and the first version of > this patch is already in 'pu'... **runs to check the trace logs** > > Great, it seems we are in luck, as the secret token was specified as an > encrypted environment variable in git/git repository settings on Travis > CI. It's redacted in the trace log [...]
That's good enough.
Thanks for making sure, Dscho