Re: [PATCH v2 8/8] travis-ci: only print test failures if there are

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Dec 17, 2017, 00:02 UTC
Message-ID: <CAPig+cR2FE1Gtw5LWUVHgiVwA1++YXKjLgkeN+3MjNzP1=Tguw@mail.gmail.com>
In-Reply-To: <20171216224839.11372-1-szeder.dev@gmail.com>

On Sat, Dec 16, 2017 at 5:48 PM, SZEDER Gábor <szeder.dev@gmail.com> wrote:

Show 11 quoted lines

> On Sat, Dec 16, 2017, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> I'd think you'd want to capture the result of the expansion of
>> t/test-result/*.exit as a string and compare that instead.
>
> I'm not sure how the result of the expansion could be captured in the
> shell, because the shell performs the expansion only just before it
> executes a command.  And if we do have to execute a command anyway,
> then we can simply rely on the command exiting with an error code upon
> not finding any files, and there's no need to capture the expansion or
> for the comparison for that matter.
> So I propose this updated patch, using 'ls' instead of 'test':

To capture the expansion as a string, I was thinking along the lines of:

    x=$(echo t/test-results/*.exit)

but that's a minor point. Checking the explicit exit code of a command, as you suggest, is probably cleaner.