git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] completion: improvements for git stash

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 20, 2018, 01:38 UTC
Message-ID
<xmqq36zqd5dg.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180419232514.16572-1-t.gummerer@gmail.com>
Thomas Gummerer <t.gummerer@gmail.com> writes:
Show 11 quoted lines
> I didn't find a good way to implement "reluctant completion" (I'm also
> by no means an expert in bash completion, so there may well be a way I
> couldn't find by googl'ing around), so I left that out of this
> series.
>
> I don't think it's strictly necessary for the deprecation either, as
> we can just print a warning message when the user actually uses 'git
> stash save' at some point, which would make a message printed when
> using the completion redundant anyway.  I feel like that warning
> message is not something we're quite ready for yet and I'd rather wait
> a few more releases before doing that though.
Yeah, I agree that what you outined above is quite sensible.
Thanks, will queue.
Previous: Thomas Gummerer
Message 12 of 12 in “completion: improvements for git stash”
  1. 0/3 completion: improvements for git stashThomas Gummerer, Apr 17, 2018
  2. 1/3 completion: rename save_opts to default_opts for stashThomas Gummerer, Apr 17, 2018
  3. 2/3 completion: stop completing 'save' as stash subcommandThomas Gummerer, Apr 17, 2018
  4. 3/3 completion: make stash -p and alias for stash push -pThomas Gummerer, Apr 17, 2018
  5. Junio C HamanoApr 18, 2018
  6. Thomas GummererApr 18, 2018
  7. 0/2 completion: improvements for git stashThomas Gummerer, Apr 19, 2018
  8. 1/2 completion: stop showing 'save' for stash by defaultThomas Gummerer, Apr 19, 2018
  9. Duy NguyenApr 20, 2018
  10. Thomas GummererApr 22, 2018
  11. 2/2 completion: make stash -p and alias for stash push -pThomas Gummerer, Apr 19, 2018
  12. Junio C HamanoApr 20, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.