From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 20 Apr 2018 01:38:19 GMT
Subject: Re: [PATCH v2 0/2] completion: improvements for git stash
Message-ID: <xmqq36zqd5dg.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180419232514.16572-1-t.gummerer@gmail.com>

Thomas Gummerer <t.gummerer@gmail.com> writes:

> I didn't find a good way to implement "reluctant completion" (I'm also
> by no means an expert in bash completion, so there may well be a way I
> couldn't find by googl'ing around), so I left that out of this
> series.
>
> I don't think it's strictly necessary for the deprecation either, as
> we can just print a warning message when the user actually uses 'git
> stash save' at some point, which would make a message printed when
> using the completion redundant anyway.  I feel like that warning
> message is not something we're quite ready for yet and I'd rather wait
> a few more releases before doing that though.

Yeah, I agree that what you outined above is quite sensible.

Thanks, will queue.