git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] trace2: fix incorrect function pointer check

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 26, 2019, 02:42 UTC
Message-ID
<xmqq36m5wkqj.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20ceb5c3-f64f-be77-2d11-cb41a7045642@gmail.com>
Derrick Stolee <stolee@gmail.com> writes:
Show 14 quoted lines
> On 4/25/2019 1:08 PM, Josh Steadmon wrote:
>> Fix trace2_data_json_fl() to check for the presence of pfn_data_json_fl
>> in its targets, rather than pfn_data_fl, which is not actually called.
>
> [snip]
>
>>  	for_each_wanted_builtin (j, tgt_j)
>> -		if (tgt_j->pfn_data_fl)
>> +		if (tgt_j->pfn_data_json_fl)
>>  			tgt_j->pfn_data_json_fl(file, line, us_elapsed_absolute,
>
> Seems obviously correct. Thanks!
>
> -Stolee

Thanks, both. It is embarrassing and sad that nobody caught it before it hit my tree X-<.

Previous: Derrick StoleeNext: Jeff Hostetler
Message 3 of 4 in “trace2: fix incorrect function pointer check”
  1. trace2: fix incorrect function pointer checkJosh Steadmon, Apr 25, 2019
  2. Derrick StoleeApr 25, 2019
  3. Junio C HamanoApr 26, 2019
  4. Jeff HostetlerApr 29, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.