From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 26 Apr 2019 02:42:12 GMT
Subject: Re: [PATCH] trace2: fix incorrect function pointer check
Message-ID: <xmqq36m5wkqj.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20ceb5c3-f64f-be77-2d11-cb41a7045642@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

> On 4/25/2019 1:08 PM, Josh Steadmon wrote:
>> Fix trace2_data_json_fl() to check for the presence of pfn_data_json_fl
>> in its targets, rather than pfn_data_fl, which is not actually called.
>
> [snip]
>
>>  	for_each_wanted_builtin (j, tgt_j)
>> -		if (tgt_j->pfn_data_fl)
>> +		if (tgt_j->pfn_data_json_fl)
>>  			tgt_j->pfn_data_json_fl(file, line, us_elapsed_absolute,
>
> Seems obviously correct. Thanks!
>
> -Stolee

Thanks, both.  It is embarrassing and sad that nobody caught it
before it hit my tree X-<.