git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] trace2: fix incorrect function pointer check

From
Derrick Stolee <stolee@gmail.com>
Date
Apr 25, 2019, 18:46 UTC
Message-ID
<20ceb5c3-f64f-be77-2d11-cb41a7045642@gmail.com>
In-Reply-To
<548a9b833f4569c526cf94c048ae115a76d54be9.1556211995.git.steadmon@google.com>
On 4/25/2019 1:08 PM, Josh Steadmon wrote:
> Fix trace2_data_json_fl() to check for the presence of pfn_data_json_fl
> in its targets, rather than pfn_data_fl, which is not actually called.
[snip]
>  	for_each_wanted_builtin (j, tgt_j)
> -		if (tgt_j->pfn_data_fl)
> +		if (tgt_j->pfn_data_json_fl)
>  			tgt_j->pfn_data_json_fl(file, line, us_elapsed_absolute,
Seems obviously correct. Thanks!
-Stolee
Previous: Josh SteadmonNext: Junio C Hamano
Message 2 of 4 in “trace2: fix incorrect function pointer check”
  1. trace2: fix incorrect function pointer checkJosh Steadmon, Apr 25, 2019
  2. Derrick StoleeApr 25, 2019
  3. Junio C HamanoApr 26, 2019
  4. Jeff HostetlerApr 29, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.