Re: [PATCH 4/4] commit-graph: close descriptors after mmap
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 23, 2020, 22:04 UTC
- Message-ID
- <xmqq368tg8po.fsf@gitster.c.googlers.com>
- In-Reply-To
- <e05db264cb50760cab222157b436e82adeaeadc8.1587677671.git.me@ttaylorr.com>
Taylor Blau <me@ttaylorr.com> writes:
Show 5 quoted lines
> From: Jeff King <peff@peff.net> > > We don't ever refer to the descriptor after mmap-ing it. And keeping it > open means we can run out of descriptors in degenerate cases (e.g., > thousands of split chain files). Let's close it as soon as possible.
Yikes.
Sorry, I should have looked at the use of mmap in this topioc more carefully when we queued the series. It is an easy mistake to make by anybody new to the API to leave it open while the region is in use.
With this fix, with or without the other topics still in flight, I do not think no code touches graph_fd. Should we remove the graph_fd field from the structure as well?
commit-graph.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/commit-graph.h b/commit-graph.h index a0a2c4a1e5..1254eae948 100644 --- a/commit-graph.h +++ b/commit-graph.h @@ -40,8 +40,6 @@ struct tree *get_commit_tree_in_graph(struct repository *r, const struct commit *c); struct commit_graph { - int graph_fd; - const unsigned char *data; size_t data_len;