Re: [PATCH 4/4] commit-graph: close descriptors after mmap

From

Jeff King <peff@peff.net>

Date

Apr 24, 2020, 03:56 UTC

Message-ID

<20200424035628.GA1648190@coredump.intra.peff.net>

In-Reply-To

<xmqq368tg8po.fsf@gitster.c.googlers.com>

On Thu, Apr 23, 2020 at 03:04:19PM -0700, Junio C Hamano wrote:

> With this fix, with or without the other topics still in flight, I
> do not think no code touches graph_fd.  Should we remove the
> graph_fd field from the structure as well?

Oops, I thought I did.

> diff --git a/commit-graph.h b/commit-graph.h
> index a0a2c4a1e5..1254eae948 100644
> --- a/commit-graph.h
> +++ b/commit-graph.h
> @@ -40,8 +40,6 @@ struct tree *get_commit_tree_in_graph(struct repository *r,
>  				      const struct commit *c);
>  
>  struct commit_graph {
> -	int graph_fd;
> -

Yes, this should definitely be squashed in.

-Peff