[PATCH 1/4] commit-graph.c: don't use discarded graph_name in error
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Apr 23, 2020, 21:41 UTC
- Message-ID
- <17dff6142e62d202794986f0bd51e4a8604f8e49.1587677671.git.me@ttaylorr.com>
- In-Reply-To
- <cover.1587677671.git.me@ttaylorr.com>
When writing a commit-graph layer, we do so in a temporary file which is renamed into place. If we fail to create a temporary file, for e.g., because we have too many open files, then 'git_mkstemp_mode' sets the pattern to the empty string, in which case we get an error something along the lines of:
error: unable to create ''
It's not useful to show the pattern here at all, since we (1) know the pattern is well-formed, and (2) would have already shown the dirname when trying to create the leading directories. So, replace this error with something friendlier.
Signed-off-by: Taylor Blau <me@ttaylorr.com> --- commit-graph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/commit-graph.c b/commit-graph.c index b8737f0ce9..afde075962 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -1397,7 +1397,7 @@ static int write_commit_graph_file(struct write_commit_graph_context *ctx) fd = git_mkstemp_mode(ctx->graph_name, 0444); if (fd < 0) { - error(_("unable to create '%s'"), ctx->graph_name); + error(_("unable to create temporary graph layer")); return -1; }
-- 2.26.0.113.ge9739cdccc