Re: [PATCH v3 0/3] Accommodate for pu having been renamed to seen

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 25, 2020, 16:22 UTC
Message-ID: <xmqq366j5d57.fsf@gitster.c.googlers.com>
In-Reply-To: <pull.668.v3.git.1593087539.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 14 quoted lines

> This patch series adjusts Git's own source code to reflect that change.
>
> Please note that even with these patches, there are still a couple places
> where pu is used:
>
>  * In the translations. These are legitimate words in languages that are not
>    English (as in "gpg n'a pas pu signer les données" where "pu" is French
>    for the English "could").
>  * In upload-pack.c, where a variable named pu is short form for
>    "pack-objects updates".
>
> Changes since v2:
>
>  * One accidental quoting change in v1 was reverted.

Thanks for being thorough.

You could have just told me that the fixup queued on 'seen' looks good to you and squash it in the first step instead to save one roundtrip, but replacing with a new set of three patches is not so bad, either ;-)

Will replace.