Re: [PATCH v3 0/3] Accommodate for pu having been renamed to seen
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 29, 2020, 14:07 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2006291606060.56@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqq366j5d57.fsf@gitster.c.googlers.com>
Hi Junio,
On Thu, 25 Jun 2020, Junio C Hamano wrote:
Show 24 quoted lines
> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> > writes: > > > This patch series adjusts Git's own source code to reflect that change. > > > > Please note that even with these patches, there are still a couple places > > where pu is used: > > > > * In the translations. These are legitimate words in languages that are not > > English (as in "gpg n'a pas pu signer les données" where "pu" is French > > for the English "could"). > > * In upload-pack.c, where a variable named pu is short form for > > "pack-objects updates". > > > > Changes since v2: > > > > * One accidental quoting change in v1 was reverted. > > Thanks for being thorough. > > You could have just told me that the fixup queued on 'seen' looks > good to you and squash it in the first step instead to save one > roundtrip, but replacing with a new set of three patches is not so > bad, either ;-)
To be honest, the GitGitGadget-based workflow makes it quicker for me to just submit a new iteration. In fact, I did not even see your fixup until I read your mail.
Ciao, Dscho
> > Will replace. > >