Re: What's cooking in git.git (Jan 2025, #05; Fri, 17)

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 18, 2025, 17:17 UTC
Message-ID: <xmqq34hg3utv.fsf@gitster.g>
In-Reply-To: <20250118131507.GA387197@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

> On Fri, Jan 17, 2025 at 04:42:01PM -0800, Junio C Hamano wrote:
>
>> * jk/pack-header-parse-alignment-fix (2025-01-17) 3 commits
>> ...
>>  Will merge to 'next'.
>>  source: <20250117125207.GB2356599@coredump.intra.peff.net>
>
> I was planning to re-roll this with your sparse fix included, and adding
> another patch to do get_be32() on the reading side. So maybe hold off
> for a moment.

Thanks.

> (I'd also be interested in any comments on the "maybe we should just
> align these buffers" approach; I'm undecided on it).

Unless we have the buffer _inside_ the helper function that may perform the possibly-unaligned access, I am not sure how it helps.

I guess that we can align buffers used by two existing callers, document that the helper function takes an aligned buffer and that it is a fault of the caller if somebody passes an unaligned buffer, but I am not sure if that is where we want to go.