git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Jan 2025, #05; Fri, 17)

From
Taylor Blau <me@ttaylorr.com>
Date
Jan 23, 2025, 23:05 UTC
Message-ID
<Z5LLNMKSa6Y2zvHK@nand.local>
In-Reply-To
<xmqqh65qv6oc.fsf@gitster.g>
On Wed, Jan 22, 2025 at 02:13:07PM -0800, Junio C Hamano wrote:
Show 26 quoted lines
> Taylor Blau <me@ttaylorr.com> writes:
>
> > On Tue, Jan 21, 2025 at 12:30:08PM -0800, Junio C Hamano wrote:
> >> Derrick Stolee <stolee@gmail.com> writes:
> >>
> >> > On 1/17/25 7:42 PM, Junio C Hamano wrote:
> >> >
> >> >> * ds/name-hash-tweaks (2024-12-20) 8 commits
> >> ...
> >> I am happy with the updated function that gives us better of both
> >> worlds, without losing too much from the "renamed from other
> >> directory" while making sure we do not lose too many bits in deeper
> >> trees.
> >
> > I had a couple of thoughts that I meant to share before the holiday
> > break, and haven't quite had a chance to get to it now that I'm back at
> > my desk.
> >
> > Let me try and find some time to respond to the latest round of this
> > series, and apologies for holding it up in the meantime.
>
> The topic has been stalled for unusually long time, so it won't hurt
> too much for it to wait for a few more days, but it wouldn't be fair
> to stall a topic further with just a promise to "try and find time"
> forever.  Let's say we'll go ahead by this weekend unless we hear
> otherwise?

I agree, and I apologize for the delay. I prioritized this yesterday and left some review which I think you have seen since sending this email.

Show 7 quoted lines
> I am not ultra-happy with the last step, as I personally do not see
> this different algorithm as "version" (in that people would always
> want to use version N+1 over version N when both are available) but
> as "variant" (in that there may be prefer to use variant N over
> variant N+1 depending on the circumstances), but that may be just
> the matter of terminology.  What's important is to make sure we do
> not mix two algorhtims up while creating a packfile.

Yeah, I think "variant" is probably more accurate, but I don't mind the naming. I think having a unique identifier is important, but I am not convinced that we need to introduce v2 and v3 at the same time. I would rather see us unify behind a single approach to present a clearer/smaller set of options to users.

Thanks, Taylor

Previous: Junio C HamanoNext: Junio C Hamano
Message 14 of 23 in “What's cooking in git.git (Jan 2025, #05; Fri, 17)”
  1. Junio C HamanoJan 18, 2025
  2. Jeff KingJan 18, 2025
  3. Junio C HamanoJan 18, 2025
  4. Jeff KingJan 19, 2025
  5. Jeff KingJan 19, 2025
  6. Junio C HamanoJan 21, 2025
  7. David AguilarJan 20, 2025
  8. help: make help.autocorrect = 1 the same as "prompt"David Aguilar, Jan 20, 2025
  9. Junio C HamanoJan 21, 2025
  10. Derrick StoleeJan 21, 2025
  11. Junio C HamanoJan 21, 2025
  12. Taylor BlauJan 22, 2025
  13. Junio C HamanoJan 22, 2025
  14. Taylor BlauJan 23, 2025
  15. Junio C HamanoJan 23, 2025
  16. Karthik NayakJan 22, 2025
  17. Karthik NayakJan 22, 2025
  18. Junio C HamanoJan 22, 2025
  19. Junio C HamanoJan 23, 2025
  20. Patrick SteinhardtJan 23, 2025
  21. Junio C HamanoJan 23, 2025
  22. Karthik NayakJan 24, 2025
  23. Junio C HamanoJan 24, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.