Re: What's cooking in git.git (Jan 2025, #05; Fri, 17)

From: Jeff King <peff@peff.net>
Date: Jan 19, 2025, 12:55 UTC
Message-ID: <20250119125526.GA1540196@coredump.intra.peff.net>
In-Reply-To: <20250119125146.GB1538605@coredump.intra.peff.net>

On Sun, Jan 19, 2025 at 07:51:46AM -0500, Jeff King wrote:

Show 7 quoted lines

> > Unless we have the buffer _inside_ the helper function that may
> > perform the possibly-unaligned access, I am not sure how it helps.
> 
> We sort-of do. The offending code is all static local to
> unpack-objects.c, and always operates on the same buffer (directly for
> writing, and for reading through the static fill() macro which returns
> it directly). And likewise in index-pack.c.

Oh, reading this again, I guess you were thinking of the helper that I had factored out. Yes, if that requires aligned memory that is an awful interface. :-/

I was thinking to just leave the offending code untouched in the individual commands if we went this route.

But anyway, I'll prepare a version going the other get_be32() direction.

-Peff