Re: [PATCH v2 2/2] gpg-interface: remove an unnecessary NULL initialization

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 6, 2026, 01:59 UTC
Message-ID: <xmqq343ek4y6.fsf@gitster.g>
In-Reply-To: <8d188ce1b8994f0108b49a4cad8af425b09504fd.1770342268.git.collin.funk1@gmail.com>

Collin Funk <collin.funk1@gmail.com> writes:

> We assign this variable unconditionally, so we do not need to assign it
> to NULL where it is declared.

The latter "assign" is better phrased as "initialize", but other than that this looks great.

Thanks.

Show 19 quoted lines

>
> Signed-off-by: Collin Funk <collin.funk1@gmail.com>
> ---
>  gpg-interface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gpg-interface.c b/gpg-interface.c
> index 377c0cf49f..87fb6605fb 100644
> --- a/gpg-interface.c
> +++ b/gpg-interface.c
> @@ -398,7 +398,7 @@ static void parse_ssh_output(struct signature_check *sigc)
>  {
>  	const char *line, *principal, *search;
>  	char *to_free;
> -	const char *key = NULL;
> +	const char *key;
>  
>  	/*
>  	 * ssh-keygen output should be: