Re: [PATCH] global: constify some pointers that are not written to
- From
Jeff King <peff@peff.net>
- Date
- Feb 5, 2026, 07:41 UTC
- Message-ID
- <20260205074139.GA1019015@coredump.intra.peff.net>
- In-Reply-To
- <342b01acd42f1fcaa3abefa38dc589e12ccb1134.1770261829.git.collin.funk1@gmail.com>
On Wed, Feb 04, 2026 at 07:24:19PM -0800, Collin Funk wrote:
> This patch fixes the more obvious ones by making them const when we do > not write to the returned pointer.
Thanks, this looks like a good start. All of the changes look correct to me (and can be confirmed with the compiler). I also cross-checked them against my own earlier hacky pass. The only difference was in this hunk:
Show 10 quoted lines
> diff --git a/gpg-interface.c b/gpg-interface.c
> index 47222bf31b..87fb6605fb 100644
> --- a/gpg-interface.c
> +++ b/gpg-interface.c
> @@ -398,7 +398,7 @@ static void parse_ssh_output(struct signature_check *sigc)
> {
> const char *line, *principal, *search;
> char *to_free;
> - char *key = NULL;
> + const char *key;You've dropped the NULL initialization here. That's OK to do, as the NULL is never used (we assign "key" immediately before the first time we look at it). But it probably makes sense for this patch to change only one thing. So either leave the dead initialization, or remove it as a separate patch.
-Peff