git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/2] gpg-interface: remove an unnecessary NULL initialization

From
Collin Funk <collin.funk1@gmail.com>
Date
Feb 6, 2026, 01:46 UTC
Message-ID
<8d188ce1b8994f0108b49a4cad8af425b09504fd.1770342268.git.collin.funk1@gmail.com>
In-Reply-To
<a53fd33b5696487f941faace90f51153555ce8f4.1770342268.git.collin.funk1@gmail.com>

We assign this variable unconditionally, so we do not need to assign it to NULL where it is declared.

Signed-off-by: Collin Funk <collin.funk1@gmail.com>
---
 gpg-interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gpg-interface.c b/gpg-interface.c
index 377c0cf49f..87fb6605fb 100644
--- a/gpg-interface.c
+++ b/gpg-interface.c
@@ -398,7 +398,7 @@ static void parse_ssh_output(struct signature_check *sigc)
 {
 	const char *line, *principal, *search;
 	char *to_free;
-	const char *key = NULL;
+	const char *key;
 
 	/*
 	 * ssh-keygen output should be:
-- 
2.53.0
Previous: Collin FunkNext: Junio C Hamano
Message 6 of 8 in “global: constify some pointers that are not written to”
  1. global: constify some pointers that are not written toCollin Funk, Feb 5, 2026
  2. Jeff KingFeb 5, 2026
  3. Junio C HamanoFeb 5, 2026
  4. Collin FunkFeb 5, 2026
  5. 1/2 global: constify some pointers that are not written toCollin Funk, Feb 6, 2026
  6. 2/2 gpg-interface: remove an unnecessary NULL initializationCollin Funk, Feb 6, 2026
  7. Junio C HamanoFeb 6, 2026
  8. Ben KnobleFeb 6, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.