git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] object-file: avoid ODB transaction when not writing objects

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 8, 2026, 00:42 UTC
Message-ID
<xmqq34162sh1.fsf@gitster.g>
In-Reply-To
<adWGjWNTXlR-glgt@denethor>
Justin Tobler <jltobler@gmail.com> writes:
Show 31 quoted lines
> Thanks, I'll make sure to double check.
>
> I'm not sure if you already included an update for the test per Peff's
> comments, but if not we can do something like below. If you would like I
> can send another version with it included too.
>
> Thanks,
> -Justin
>
> --- >8 ---
> diff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh
> index c1dbc6359a..e1d35170de 100755
> --- a/t/t1517-outside-repo.sh
> +++ b/t/t1517-outside-repo.sh
> @@ -93,12 +93,12 @@ test_expect_success 'diff outside repository' '
>  	test_cmp expect actual
>  '
>  
> -test_expect_success 'diff files exceeding bigFileThreshold outside repository' '
> -	cd non-repo &&
> -	echo foo >foo &&
> -	echo bar >bar &&
> -	test_must_fail git -c core.bigFileThreshold=1 diff -- foo bar >actual &&
> -	test_grep "diff --git a/foo b/bar" actual
> +test_expect_success 'hash object exceeding bigFileThreshold outside repository' '
> +	(
> +		cd non-repo &&
> +		echo foo >foo &&
> +		git -c core.bigFileThreshold=1 hash-object --stdin <foo
> +	)
>  '
I'll redo the material with the above.
Previous: Justin Tobler
Message 10 of 10 in “object-file: avoid ODB transaction when not writing objects”
  1. object-file: avoid ODB transaction when not writing objectsJustin Tobler, Apr 7, 2026
  2. Junio C HamanoApr 7, 2026
  3. Jeff KingApr 7, 2026
  4. Junio C HamanoApr 7, 2026
  5. Justin ToblerApr 7, 2026
  6. Junio C HamanoApr 7, 2026
  7. Justin ToblerApr 7, 2026
  8. Junio C HamanoApr 7, 2026
  9. Justin ToblerApr 7, 2026
  10. Junio C HamanoApr 8, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.