git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] object-file: avoid ODB transaction when not writing objects

From
Justin Tobler <jltobler@gmail.com>
Date
Apr 7, 2026, 22:08 UTC
Message-ID
<adV-NI-t6-jgJK7D@denethor>
In-Reply-To
<xmqqfr563099.fsf@gitster.g>
On 26/04/07 02:53PM, Junio C Hamano wrote:
Show 12 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > I'd appreciate it if you can give your eyeballs to the attached to
> > see if that is how you would fixed the bug in the original context
> > of v2.52 track.  If everything looks OK, then there is no need to
> > spend time backporting on your side.  We have everything necessary.
> 
> Another thing.  Your jt/odb-transaction-write topic (in 'seen')
> already addresses this issue, so we may merge this single patch down
> to 'next' and 'master' first, but the merge that brings in the topic
> can just supersede this patch, perhaps keeping the test added to
> t1517.
That would work :)
> Do I understand correctly?  The t1517 part of the patch, when
> applied to 'seen', does indicate that the problem is not there.

Yes, that is correct. The jt/odb-transaction-write topic indeed already fixes this issue. The patch here is just a slimmed down version of a patch from that series.

I can also send a follow up version for the topic built on top of this patch if that would be preferred. Otherwise, replacing the patch with the original topic and keeping the test as you suggested would work just fine.

Thanks, -Justin

Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 10 in “object-file: avoid ODB transaction when not writing objects”
  1. object-file: avoid ODB transaction when not writing objectsJustin Tobler, Apr 7, 2026
  2. Junio C HamanoApr 7, 2026
  3. Jeff KingApr 7, 2026
  4. Junio C HamanoApr 7, 2026
  5. Justin ToblerApr 7, 2026
  6. Junio C HamanoApr 7, 2026
  7. Justin ToblerApr 7, 2026
  8. Junio C HamanoApr 7, 2026
  9. Justin ToblerApr 7, 2026
  10. Junio C HamanoApr 8, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.