From: Junio C Hamano Date: Wed, 08 Apr 2026 00:42:02 GMT Subject: Re: [PATCH] object-file: avoid ODB transaction when not writing objects Message-ID: In-Reply-To: Justin Tobler writes: > Thanks, I'll make sure to double check. > > I'm not sure if you already included an update for the test per Peff's > comments, but if not we can do something like below. If you would like I > can send another version with it included too. > > Thanks, > -Justin > > --- >8 --- > diff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh > index c1dbc6359a..e1d35170de 100755 > --- a/t/t1517-outside-repo.sh > +++ b/t/t1517-outside-repo.sh > @@ -93,12 +93,12 @@ test_expect_success 'diff outside repository' ' > test_cmp expect actual > ' > > -test_expect_success 'diff files exceeding bigFileThreshold outside repository' ' > - cd non-repo && > - echo foo >foo && > - echo bar >bar && > - test_must_fail git -c core.bigFileThreshold=1 diff -- foo bar >actual && > - test_grep "diff --git a/foo b/bar" actual > +test_expect_success 'hash object exceeding bigFileThreshold outside repository' ' > + ( > + cd non-repo && > + echo foo >foo && > + git -c core.bigFileThreshold=1 hash-object --stdin + ) > ' I'll redo the material with the above.