Re: [Outreachy PATCH v3] credential-store: add lockTimeout config option
Okhuomon Ajayi <okhuomonajayi54@gmail.com> writes:
Show 17 quoted lines
> The other settings that retry taking a file lock are measured in
> milliseconds and do not put the unit in the name:
> rerere.lockTimeout, reftable.lockTimeout, core.filesRefLockTimeout,
> core.packedRefsTimeout, and core.configLockTimeout.
> credentialStore.lockTimeoutMS spells the unit out.
>
> Add credentialStore.lockTimeout as the matching name. Keep
> lockTimeoutMS as a deprecated synonym so existing configuration
> still works. The value is still milliseconds, which the
> documentation states.
>
> Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
> ---
> Changes since v2:
> - Reword the message to say why the new name drops the unit. The
> other file-lock retries are milliseconds and do not put the unit
> in the name.
Looks good. Let me mark the topic as ready for 'next'.
Thanks.