Re: [Outreachy PATCH v2] credential-store: add lockTimeout config option
- From
- Okhuomon Ajayi <okhuomonajayi54@gmail.com>
- Date
- Nov 15, 2026, 15:13 UTC
- Message-ID
- <CAFpMFfA8ikP5SGprCYvtgAQCT1y8UwCDDjpu6us2OWDkq1L1Hg@mail.gmail.com>
- In-Reply-To
- <xmqqeccphi2p.fsf@gitster.g>
On Thu, Nov 12, 2026 at 10:10 PM Junio C Hamano <gitster@pobox.com> wrote:
> Hmph, does this change even make sense? > > Sure, there are many variables whose name ends with "timeout". But > are they all measured in milliseconds?
The other settings that retry taking a file lock are measured in milliseconds and do not put the unit in the name: rerere.lockTimeout, reftable.lockTimeout, core.filesRefLockTimeout, core.packedRefsTimeout, and core.configLockTimeout. credentialStore.lockTimeoutMS spells the unit out.
The value is still milliseconds, which the documentation states. credential-cache --timeout is a different setting and is in seconds, so I am only lining this name up with the other lock retries.
I'll resend with that reason in the log message.
Thanks,
Okhuomon