Re: [PATCH v4 2/4] gitweb: vertically centre contents of page footer

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 20, 2013, 19:53 UTC
Message-ID: <xmqq1u5ow33c.fsf@gitster.dls.corp.google.com>
In-Reply-To: <5c4afd189553d0f1e83b0c2b9758643deba5a671.1377019362.git.dot@dotat.at>

Tony Finch <dot@dotat.at> writes:

Show 24 quoted lines

> Signed-off-by: Tony Finch <dot@dotat.at>
> ---
>  gitweb/static/gitweb.css | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css
> index a869be1..3b4d833 100644
> --- a/gitweb/static/gitweb.css
> +++ b/gitweb/static/gitweb.css
> @@ -68,12 +68,13 @@ div.page_path {
>  }
>  
>  div.page_footer {
> -	height: 17px;
> +	height: 22px;
>  	padding: 4px 8px;
>  	background-color: #d9d8d1;
>  }
>  
>  div.page_footer_text {
> +	line-height: 22px;
>  	float: left;
>  	color: #555555;
>  	font-style: italic;

Hmmm, is it a good idea to do "px" here, or are they ways to do relative to x-height or something to make sure the text fits?