[PATCH v4 4/4] gitweb: make search help link less ugly
- From
Tony Finch <dot@dotat.at>
- Date
- Aug 20, 2013, 16:59 UTC
- Message-ID
- <3a61bd631c264ac398271af34400809dc2fa0429.1377019362.git.dot@dotat.at>
- In-Reply-To
- <cover.1377019362.git.dot@dotat.at>
The search help link was a superscript question mark right next to a drop-down menu, which looks misaligned and is a cramped and awkward click target. Remove the superscript tags and add some spacing to fix these nits. Add a title attribute to provide an explanatory mouseover.
Signed-off-by: Tony Finch <dot@dotat.at> --- gitweb/gitweb.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 8d69ada..59af7de 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -4030,8 +4030,8 @@ sub print_search_form { $cgi->input({-name=>"h", -value=>$search_hash, -type=>"hidden"}) . "\n" . $cgi->popup_menu(-name => 'st', -default => 'commit', -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) . - $cgi->sup($cgi->a({-href => href(action=>"search_help")}, "?")) . - " search:\n", + " " . $cgi->a({-href => href(action=>"search_help"), + -title => "search help" }, "?") . " search:\n", $cgi->textfield(-name => "s", -value => $searchtext, -override => 1) . "\n" . "<span title=\"Extended regular expression\">" . $cgi->checkbox(-name => 'sr', -value => 1, -label => 're',
-- 1.8.3.1.605.g85318f5