Re: [PATCH v4 2/4] gitweb: vertically centre contents of page footer

From: Tony Finch <dot@dotat.at>
Date: Aug 21, 2013, 09:06 UTC
Message-ID: <alpine.LSU.2.00.1308211003040.6019@hermes-2.csi.cam.ac.uk>
In-Reply-To: <xmqq1u5ow33c.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

> Tony Finch <dot@dotat.at> writes:
>
> >  div.page_footer {
> > -	height: 17px;
> > +	height: 22px;
> >  	padding: 4px 8px;
> >  	background-color: #d9d8d1;
> >  }
> >
> >  div.page_footer_text {
> > +	line-height: 22px;
> >  	float: left;
> >  	color: #555555;
> >  	font-style: italic;
>
> Hmmm, is it a good idea to do "px" here, or are they ways to do
> relative to x-height or something to make sure the text fits?

Good question. I also don't know much about css. I basically followed the style that was already there, and found out about vertical centering using line-height by searching the web.

I think font-size relative scaling would require a bigger overhaul.

Tony.

-- 
f.anthony.n.finch  <dot@dotat.at>  http://dotat.at/
Forties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first.
Rough, becoming slight or moderate. Showers, rain at first. Moderate or good,
occasionally poor at first.