Re: [PATCH 2/2] mergetool: run prompt only if guessed tool

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 24, 2014, 18:30 UTC
Message-ID: <xmqq1twmwpfy.fsf@gitster.dls.corp.google.com>
In-Reply-To: <xmqqlhuw0ybb.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 12 quoted lines

> Perhaps like this?
>
> I take that your original motivation was to confirm to run a tool on
> this particular (as opposed to another) path, but the user can also
> take the prompt as to confirm to run this (as opposed to some other)
> tool.  The latter of which of course is irritating for those who
> told which exact tool to use.
>
> I think the large part of the reason why you and Felipe had to have
> a long back-and-forth was because it was unclear that the prompt
> served these two purposes from the documentation, so I attempted to
> clarify the first motivation by adding a brief half-sentence.

I'll queue the following as a separate documentation patch. We may want to polish the wording, so I'll keep it out of 'next' for now.

I think the main patch is good for 'next' with or without doc update to be cooked during the remainder of this cycle, and I merged it there already.

Thanks.

-- >8 --
Subject: [PATCH] mergetool: document the default for --[no-]prompt

The original motivation of using the prompt was to confirm to run a tool on this particular (as opposed to another) path, but the user can also take the prompt as to confirm to run this (as opposed to some other) tool. The latter of which of course is irritating for those who told which exact tool to use, which is the reason why we are flipping the default.

During the review discussion of the patch, many people (including the maintainer) missed that a user can find the prompt useful way to skip running the tool on particular paths. Clarify it by adding a brief half-sentence to the description.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 Documentation/git-mergetool.txt | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Documentation/git-mergetool.txt b/Documentation/git-mergetool.txt
index 07137f2..e846c2e 100644
--- a/Documentation/git-mergetool.txt
+++ b/Documentation/git-mergetool.txt
@@ -71,11 +71,13 @@ success of the resolution after the custom tool has exited.
 --no-prompt::
 	Don't prompt before each invocation of the merge resolution
 	program.
+	This is the default if the merge resolution program is
+	explicitly specified with the `--tool` option or with the
+	`merge.tool` configuration variable.
 
 --prompt::
-	Prompt before each invocation of the merge resolution program.
-	This is the default behaviour; the option is provided to
-	override any configuration settings.
+	Prompt before each invocation of the merge resolution program
+	to give the user a chance to skip the path.
 
 TEMPORARY FILES
 ---------------

-- 
2.0.0-rc0-224-g3c1c0b8