git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 01/11] ref-filter: use string_list_split over strbuf_split

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 17, 2016, 22:19 UTC
Message-ID
<xmqq1t8bhtdw.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160217221430.GA24899@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 22 quoted lines
> On Wed, Feb 17, 2016 at 05:11:50PM -0500, Eric Sunshine wrote:
>
>> On Wed, Feb 17, 2016 at 1:06 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
>> > From: Jeff King <peff@peff.net>
>> >
>> > We don't do any post-processing on the resulting strbufs, so it is
>> > simpler to just use string_list_split, which takes care of removing
>> > the delimiter for us.
>> >
>> > Written-by: Jeff King <peff@peff.net>
>> 
>> Perhaps Peff can give his sign-off...
>
> Ah, right. I usually sign-off when sending to the list, so the version
> he pulled from GitHub didn't have it.
>
> Definitely:
>
>   Signed-off-by: Jeff King <peff@peff.net>
>
> And I don't think "Written-by" was doing much here, anyway; I am already
> the author by the From header at the top. :)
;-).
So, is everybody happy with this round?

With another series on top for the "conditional" stuff, I guess we are ready to do the formatting for "git branch --list", which would be a big step forward.

Thanks.
Previous: Jeff KingNext: Eric Sunshine
Message 5 of 18 in “ref-filter: use parsing functions”
  1. 00/11 ref-filter: use parsing functionsKarthik Nayak, Feb 17, 2016
  2. 01/11 ref-filter: use string_list_split over strbuf_splitKarthik Nayak, Feb 17, 2016
  3. Eric SunshineFeb 17, 2016
  4. Jeff KingFeb 17, 2016
  5. Junio C HamanoFeb 17, 2016
  6. Eric SunshineFeb 17, 2016
  7. Jeff KingFeb 17, 2016
  8. Karthik NayakFeb 18, 2016
  9. 02/11 ref-filter: bump 'used_atom' and related code to the topKarthik Nayak, Feb 17, 2016
  10. 03/11 ref-filter: introduce struct used_atomKarthik Nayak, Feb 17, 2016
  11. 04/11 ref-filter: introduce parsing functions for each valid atomKarthik Nayak, Feb 17, 2016
  12. 05/11 ref-filter: introduce color_atom_parser()Karthik Nayak, Feb 17, 2016
  13. 06/11 ref-filter: introduce parse_align_position()Karthik Nayak, Feb 17, 2016
  14. 07/11 ref-filter: introduce align_atom_parser()Karthik Nayak, Feb 17, 2016
  15. 08/11 ref-filter: align: introduce long-form syntaxKarthik Nayak, Feb 17, 2016
  16. 09/11 ref-filter: introduce remote_ref_atom_parser()Karthik Nayak, Feb 17, 2016
  17. 10/11 ref-filter: introduce contents_atom_parser()Karthik Nayak, Feb 17, 2016
  18. 11/11 ref-filter: introduce objectname_atom_parser()Karthik Nayak, Feb 17, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.