From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 17 Feb 2016 22:19:39 GMT
Subject: Re: [PATCH v6 01/11] ref-filter: use string_list_split over strbuf_split
Message-ID: <xmqq1t8bhtdw.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160217221430.GA24899@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Wed, Feb 17, 2016 at 05:11:50PM -0500, Eric Sunshine wrote:
>
>> On Wed, Feb 17, 2016 at 1:06 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
>> > From: Jeff King <peff@peff.net>
>> >
>> > We don't do any post-processing on the resulting strbufs, so it is
>> > simpler to just use string_list_split, which takes care of removing
>> > the delimiter for us.
>> >
>> > Written-by: Jeff King <peff@peff.net>
>> 
>> Perhaps Peff can give his sign-off...
>
> Ah, right. I usually sign-off when sending to the list, so the version
> he pulled from GitHub didn't have it.
>
> Definitely:
>
>   Signed-off-by: Jeff King <peff@peff.net>
>
> And I don't think "Written-by" was doing much here, anyway; I am already
> the author by the From header at the top. :)

;-).

So, is everybody happy with this round?

With another series on top for the "conditional" stuff, I guess we
are ready to do the formatting for "git branch --list", which would
be a big step forward.

Thanks.