Re: [PATCH v6 01/11] ref-filter: use string_list_split over strbuf_split

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Feb 17, 2016, 22:21 UTC
Message-ID: <CAPig+cS8sJn9tV2kW=ASN2wTtKiK-H5oa8bThiiGfu_vMv7DoQ@mail.gmail.com>
In-Reply-To: <xmqq1t8bhtdw.fsf@gitster.mtv.corp.google.com>

On Wed, Feb 17, 2016 at 5:19 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 26 quoted lines

> Jeff King <peff@peff.net> writes:
>> On Wed, Feb 17, 2016 at 05:11:50PM -0500, Eric Sunshine wrote:
>>> On Wed, Feb 17, 2016 at 1:06 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
>>> > From: Jeff King <peff@peff.net>
>>> >
>>> > We don't do any post-processing on the resulting strbufs, so it is
>>> > simpler to just use string_list_split, which takes care of removing
>>> > the delimiter for us.
>>> >
>>> > Written-by: Jeff King <peff@peff.net>
>>>
>>> Perhaps Peff can give his sign-off...
>>
>> Ah, right. I usually sign-off when sending to the list, so the version
>> he pulled from GitHub didn't have it.
>>
>> Definitely:
>>
>>   Signed-off-by: Jeff King <peff@peff.net>
>>
>> And I don't think "Written-by" was doing much here, anyway; I am already
>> the author by the From header at the top. :)
>
> ;-).
>
> So, is everybody happy with this round?

Yes, v6 looks good to me and is:

Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>