Re: [PATCH v9 10/14] pkt-line: add functions to read/write flush terminated packet streams
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 4, 2016, 19:58 UTC
- Message-ID
- <xmqq1szvubsb.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <xmqq8tu3ubzl.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
> I must be missing something. Is the other side always supposed to > give a flush packet or something? Perhaps that is what is happening > here. If so, I am OK with that, even though it somehow sounds a bit > wasteful.
Ah, scratch that. What I was missing was that this channel is designed to carry multiple interactions and delimiting with EOF which by definition can happen only once cannot be a norm. Expecting a flush to declare the current stream terminated is perfectly fine.