Re: [PATCH v9 04/14] run-command: add wait_on_exit

> On 06 Oct 2016, at 11:32, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:
> 
> Hi Junio & Lars,
> 
> On Wed, 5 Oct 2016, Junio C Hamano wrote:
> 
>> Lars Schneider <larsxschneider@gmail.com> writes:
>> 
>>> OK. Something like the patch below would work nicely.
>> 
>> Yeah, something along that line; it would eliminate the need to
>> worry about a field named "stdin" ;-)
> 
> Not only a need to worry. Git for Windows' SDK's headers define
> 
> 	#define stdin (&__iob_func()[0])
> 
> leading to the compile error
> 
> 	In file included from git-compat-util.h:159:0,
>                 from cache.h:4,
>                 from run-command.c:1:
> 	run-command.c:25:6: error: expected identifier or '(' before '&' token
> 	  int stdin;
> 	      ^
> 
> I meant to investigate this build failure of `pu` earlier but only got
> around to do it today.
> 
> Ciao,
> Dscho