Re: [PATCH v9 04/14] run-command: add wait_on_exit

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 6, 2016, 09:32 UTC
Message-ID: <alpine.DEB.2.20.1610061129430.35196@virtualbox>
In-Reply-To: <xmqqeg3uo5yt.fsf@gitster.mtv.corp.google.com>

Hi Junio & Lars,

On Wed, 5 Oct 2016, Junio C Hamano wrote:

Show 6 quoted lines

> Lars Schneider <larsxschneider@gmail.com> writes:
> 
> > OK. Something like the patch below would work nicely.
> 
> Yeah, something along that line; it would eliminate the need to
> worry about a field named "stdin" ;-)

Not only a need to worry. Git for Windows' SDK's headers define

	#define stdin (&__iob_func()[0])

leading to the compile error

	In file included from git-compat-util.h:159:0,
                 from cache.h:4,
                 from run-command.c:1:
	run-command.c:25:6: error: expected identifier or '(' before '&' token
	  int stdin;
	      ^

I meant to investigate this build failure of `pu` earlier but only got around to do it today.

Ciao, Dscho

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.