Re: [PATCH] mingw: make stderr unbuffered again

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 16, 2017, 18:01 UTC
Message-ID: <xmqq1suyypyv.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <d1c65a34-3809-ee76-5e00-69ba715e0093@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

Show 11 quoted lines

> Am 16.02.2017 um 18:10 schrieb Johannes Schindelin:
>> On Wed, 15 Feb 2017, Johannes Sixt wrote:
>>> I do not see how dup2() causes a change in stdio state. I
>>> must be missing something (and that may be a basic misunderstanding of how
>>> stdio is initialized).
>>
>> It appears that dup2()ing fd 2 resets that stdio state.
>
> OK, thanks. It's surprising, but so be it.
>
> Thank you for the quick fix!

I am happy to see two Windows folks being happy. I tentatively marked this as "undecided" after merging it to 'next', but let's have it in the -rc2 and final. Two people familiar with Windows agreeing that there is no longer mystery why it fixes, after seeing that the update fixes a regression, is a strong enough sign to me that including it is better than leaving it out.

Thanks.